Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Course list for Chennai #248

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Conversation

syedomar1
Copy link
Contributor

I have updated the Course list for Fall semester 2024-25.

@therealsujitk @vatz88 Please do review the changes made in the file with the same format.

I have updated the latest Fall semester FFCS course list for 2024-25.
Updated lastUpdated value
@therealsujitk
Copy link
Collaborator

Hey @syedomar1, thanks for this PR! Seems like there are a few issues with the uploaded .xlsx file, some slot strings are cut short. Can you see if you can fix them?

Screenshot 2024-06-26 at 23 21 31

@syedomar1
Copy link
Contributor Author

@therealsujitk Thanks for noticing that and letting me know..
It was a fault in the pdf itself and I have resolved that issue.

@vatz88
Copy link
Owner

vatz88 commented Jun 26, 2024

Thanks for the PR @syedomar1 !

I'd say please test this thoroughly before merging @syedomar1 @therealsujitk

@vatz88 vatz88 requested a review from therealsujitk June 26, 2024 19:40
@therealsujitk
Copy link
Collaborator

@therealsujitk Thanks for noticing that and letting me know.. It was a fault in the pdf itself and I have resolved that issue.

I can still see the same issues 2087, 2092, 2093, 2106 - 2109. There records don't seem right to me. Maybe use a different pdf to xlsx converter or maybe share the PDF file here so one of us can try converting it.

Updated Existing file by correcting the slots.
@syedomar1
Copy link
Contributor Author

@therealsujitk I have rectified the error by correcting the slots.
I have also added pdf file for your reference. It's a mistake in the pdf itself.

@therealsujitk
Copy link
Collaborator

therealsujitk commented Jun 27, 2024

@syedomar1, this looks good. Could you check the report uploaded in #249 and let me know if it's the same one? It seems to have some differences but I'm not fully sure.

Also, can you delete the PDF file from the branch? I can't merge that into this repo.

@syedomar1
Copy link
Contributor Author

@therealsujitk As of today (27/06) 7:30pm IST they have updated the file on VTOP. Even then it doesn't match with report in #249.
I have uploaded the updated sheets by looking at each field properly and removed the pdf.
Please do review it.

Copy link
Collaborator

@therealsujitk therealsujitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@therealsujitk
Copy link
Collaborator

@syedomar1 thankyou so much for your contribution! I don't want to delay this too much either or it'll get merged after your FFCS 😅, I'll merge it now 🚀!

@therealsujitk therealsujitk merged commit 8a29469 into vatz88:master Jun 27, 2024
5 checks passed
@syedomar1
Copy link
Contributor Author

@therealsujitk Thank you! Yeah truee..😂

@therealsujitk
Copy link
Collaborator

@syedomar1 could you share an image of the timetable the Chennai campus is currently using? Maybe during your mock or actual FFCS. We're trying to add unit tests for validating .xlsx files, and are missing the following slots in our schema.

Screenshot 2024-06-27 at 23 10 52

@syedomar1
Copy link
Contributor Author

syedomar1 commented Jun 28, 2024

Sure @therealsujitk ..
We use this timetable.
tt5thsem

I think it's just that there so many random courses in the list they give.. Not sure for which course it is like PG or something and if they follow some other tt..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants