-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of VIT-AP Campus #247
Conversation
Thanks for the PR @anantgupta001 ! I'd recommend we wait until we have the data. And once we have it, we can should fully test this before merging. |
@therealsujitk if you get time, please do review these changes so we're ready merge when data is available |
There are no tests for AP related files, can you add these here --> https://github.com/vatz88/FFCSonTheGo/blob/master/tests/xlsx.test.js |
@therealsujitk all the given tasks has been completed, please do let me know if anything required. |
Also, could you resolve the conflict in |
This test means that these slots present in the course |
@anantgupta001 do you not have the latest timetable? It's better if we fix it before merging, I only said we could skip it if it was absolutely not possible to fix right now. |
@therealsujitk, I currently do not have the latest timetable. However, in some time, we will have our Fall semester 2024-25 registration. Once that occurs, I will update the information accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@vatz88 could you take a look at this too before we merge? Thanks! |
Looks fine to me. Please test it thoroughly on deploy preview before merging |
@therealsujitk If everything is functioning correctly, could you please merge all changes and close this PR? Should there be any issues or further adjustments needed, please let me know. |
Overview
This pull request addresses Issue #124 by integrating the VIT-AP campus into the existing codebase for VIT Vellore and Chennai campuses. The modifications span across multiple files, ensuring comprehensive support for the new campus.
Files Modified
Issue
Currently, we do not have an Excel sheet for VIT-AP campus data. Therefore, while the code is prepared to handle VIT-AP data, testing and full validation remain pending until the necessary data file is provided.
Request
Please review the changes and approve the integration. Additionally, once the VIT-AP Excel sheet is available, we can conduct thorough testing to ensure all functionalities work as expected.
Conclusion
The integration of VIT-AP campus has been meticulously implemented across the relevant files. Pending the provision of the required Excel sheet, we are ready to proceed with final testing and validation.
Thank you for your attention and cooperation.