Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #5

Merged
merged 145 commits into from
Dec 20, 2023
Merged
Changes from 2 commits
Commits
Show all changes
145 commits
Select commit Hold shift + click to select a range
88e148b
Initial Draft
Aug 10, 2023
601491b
Add Color
Aug 10, 2023
08ea97f
Manifest Tweaks
Aug 10, 2023
2b604b5
Move Manifest Definition to Separate Config File
Aug 10, 2023
21cd2d1
Updated sponsors and dev version
ssddanbrown Sep 7, 2023
15da4b9
Updated translations with latest Crowdin changes (#4512)
ssddanbrown Sep 7, 2023
a8b5652
Started aligning app-wide outbound http calling behaviour
ssddanbrown Sep 8, 2023
06490f6
Removed use of HttpFetcher
ssddanbrown Sep 8, 2023
8659ee0
Merge pull request #4525 from BookStackApp/http_alignment
ssddanbrown Sep 8, 2023
3928cba
Mail: changed default "MAIL_FROM" address
ssddanbrown Sep 9, 2023
2fbf552
Simplified and aligned handling of mixed entity endpoints
ssddanbrown Sep 10, 2023
564dc70
Fixed php8 compat issue, updated readme & templates
ssddanbrown Sep 11, 2023
05f2ec4
OIDC: Moved name claim option handling from config to service
ssddanbrown Sep 11, 2023
4985e39
Slack auth: Switched from community to laravel library
ssddanbrown Sep 11, 2023
99eb3e5
Comments: Fixed JS error when lacking commenting permissions
ssddanbrown Sep 11, 2023
ec86576
Merge branch 'v23-08' into development
ssddanbrown Sep 11, 2023
18f396c
Views: Rolled out ID to similar recent activity lists
ssddanbrown Sep 11, 2023
8e3f8de
Notifications: Reorgranised classes into domain specific folders
ssddanbrown Sep 11, 2023
f997d3e
Trimmed name last resort
Bajszi97 Sep 11, 2023
6e09890
Theme: Added handling for functions.php file load error
ssddanbrown Sep 12, 2023
f4deb13
Truncate with three dots
Bajszi97 Sep 12, 2023
83028f3
Test comment creator name truncation
Bajszi97 Sep 12, 2023
a452092
Reviewed #4533, formatting and tweaks
ssddanbrown Sep 13, 2023
709c182
Merge branch 'Bajszi97/development' into development
ssddanbrown Sep 13, 2023
4ec600a
Langs: Added Uzbek, Updated translator attribution
ssddanbrown Sep 13, 2023
4177056
Dark Mode: Fixed not toggle action when dark by default
ssddanbrown Sep 14, 2023
dfaf6f7
Cleanup Command: Allowed running non-interactively
ssddanbrown Sep 14, 2023
45b8d6c
Comments: Fixed wrong identification of parent comment
ssddanbrown Sep 15, 2023
80d2b49
Merge branch 'v23-08' into release
ssddanbrown Sep 15, 2023
c1d3034
Updated version and assets for release v23.08.3
ssddanbrown Sep 15, 2023
6a5361d
Fixed : Comment notification settings are visible even if comments ar…
tusharnain4578 Sep 16, 2023
9ac932f
Merge branch 'v23-08' into development
ssddanbrown Sep 16, 2023
b90033a
Guest control: Cleaned methods involved in fetching/handling
ssddanbrown Sep 16, 2023
e16bdf4
Removed redundant null check
ssddanbrown Sep 16, 2023
54791c8
Merge pull request #4554 from BookStackApp/guest_user_cleanup
ssddanbrown Sep 16, 2023
b292cf7
Extracted icon helper, aligned container resolution
ssddanbrown Sep 16, 2023
ac9a659
Locales: Performed cleanup and alignment of locale handling
ssddanbrown Sep 17, 2023
8994c1b
Locales: More use of locale objects, Addressed failing tests
ssddanbrown Sep 17, 2023
b42e8cd
Locales: Fixed errors occuring for PHP < 8.2
ssddanbrown Sep 17, 2023
baa957d
Update UserPreferencesTest.php
tusharnain4578 Sep 17, 2023
78bf11c
Locales: Removed a lot of existing locale handling
ssddanbrown Sep 17, 2023
35813e8
Merge pull request #4555 from BookStackApp/language_cleanup
ssddanbrown Sep 17, 2023
c42cd29
Notifications: Updated comment notif. prefs. test
ssddanbrown Sep 17, 2023
684a9de
Merge branch 'tusharnain4578/development' into development
ssddanbrown Sep 17, 2023
95b9ea1
Dev: Reviewed and expanded on PHP testing docs
ssddanbrown Sep 17, 2023
ea75925
feat: Artisan command for updating avatars for existing users
MarcHagen Sep 18, 2023
ca98155
fix: Actually check if we have correct data
MarcHagen Sep 18, 2023
588ed78
fix Sidebar scrolling at mid-range sceen
LawssssCat Sep 19, 2023
4b4d8ba
Avatar Commend: Simplified and updated during review
ssddanbrown Sep 19, 2023
8964575
Search: Added support for escaped exact terms
ssddanbrown Sep 19, 2023
effc03e
Merge branch 'BookStackApp:development' into basic-pwa-support
GamerClassN7 Sep 22, 2023
cb9c3fc
Fix Dark theme
Sep 22, 2023
6e19a8a
Merge branch 'basic-pwa-support' of https://github.com/GamerClassN7/B…
Sep 22, 2023
f910424
Implementation of required changes
Sep 22, 2023
9b99664
Additional Tweaks and FIxes
Sep 22, 2023
2a2f893
Formating Fixes
Sep 22, 2023
7e09c9a
Update HomeController.php
GamerClassN7 Sep 22, 2023
10e8e1a
New line fix
Sep 22, 2023
46e3b2c
Merge branch 'basic-pwa-support' of https://github.com/GamerClassN7/B…
Sep 22, 2023
57791c1
Fix Reloading changes on dark mode switch
Sep 22, 2023
fb41782
Readme: Updated badges, sponsors and top links
ssddanbrown Sep 23, 2023
f77bb01
Search: Added further backslash handling
ssddanbrown Sep 23, 2023
c3b4128
Homepage: Added tags button to non-default home views
ssddanbrown Sep 24, 2023
d5a3bdb
Header: Simplified, split and re-orgranised view file(s)
ssddanbrown Sep 24, 2023
e9664dc
Exports: Fixed issues with book text export format
ssddanbrown Sep 24, 2023
21badde
Editors: Updated entity link select to pre-fill with selection
ssddanbrown Sep 24, 2023
287ed4f
Remove Dumps
GamerClassN7 Sep 24, 2023
59da766
Uploads: Added user-facing message for Laravel post limit handling
ssddanbrown Sep 25, 2023
cc0827f
Images: Updated to create thumbnails at specific events
ssddanbrown Sep 29, 2023
5af3041
Thumbnails: Added OOM handling and regen endpoint
ssddanbrown Sep 29, 2023
5c318a4
Images: Reverted some thumbnails to be on-demand generated
ssddanbrown Sep 30, 2023
97274a8
Images: Added test to cover thubmnail regen endpoint
ssddanbrown Sep 30, 2023
4072143
Image manager: Tweaked grid sizing to prevent massive items
ssddanbrown Sep 30, 2023
7247e31
Images: Started refactor of image service
ssddanbrown Sep 30, 2023
e703009
Images: Added thin wrapper around image filesystem instances
ssddanbrown Sep 30, 2023
20bcbd7
Images: Extracted out image resizing to its own class
ssddanbrown Sep 30, 2023
b2d48d9
Images: Rolled out image memory handling to image actions
ssddanbrown Oct 1, 2023
ffb04a8
JS: Fixed ESLint issues
ssddanbrown Oct 1, 2023
8bba5dd
Merge pull request #4578 from BookStackApp/upload_handling
ssddanbrown Oct 1, 2023
1d91b4d
PWA Manifest: Tweaks during review of PR #4430
ssddanbrown Oct 2, 2023
d1f28ed
Merge branch 'basic-pwa-support' into development
ssddanbrown Oct 2, 2023
b24296e
Added NETWAYS to readme sponsor list
ssddanbrown Oct 3, 2023
1005f4b
Testing: Added favicon cleanup
ssddanbrown Oct 3, 2023
c5d5b6e
Print Styles: Fixed header/footer content showing
ssddanbrown Oct 3, 2023
bd7c7eb
Print Styles: Removed use of seperate style sheet
ssddanbrown Oct 3, 2023
0241032
Tags: Fixed enter press clearing field
ssddanbrown Oct 4, 2023
1267068
CI: Added path filtering to actions
ssddanbrown Oct 4, 2023
0310677
Layout: Restructured tri-layout for sidebar control
ssddanbrown Oct 6, 2023
2e22723
Merge branch 'LawssssCat/development' into development
ssddanbrown Oct 6, 2023
ccb3c25
Homepage: Made much nicer at ipad-like widths
ssddanbrown Oct 7, 2023
a12b60e
Editor: Started attempts to improve design elements
ssddanbrown Oct 8, 2023
45c7409
Editor: Started toying with more singificant design update
ssddanbrown Oct 13, 2023
8c10959
Editors: Tightened up new design, adjusted for MD editor
ssddanbrown Oct 14, 2023
8ffa436
Editors: Adjusted new design for mobile and dark mode
ssddanbrown Oct 14, 2023
8166e27
Editors: Properly aligned edit area border radius
ssddanbrown Oct 14, 2023
3274181
Merge pull request #4604 from BookStackApp/editor_trim_enhancement
ssddanbrown Oct 14, 2023
a9d0f36
User: Started cleanup of user self-management
ssddanbrown Oct 17, 2023
a868012
Users: Built out auth page for my-account section
ssddanbrown Oct 17, 2023
c1b0163
My Account: Built out profile page & endpoints
ssddanbrown Oct 18, 2023
03c44b3
My Account: Extracted/tweaked profile text, removed old index
ssddanbrown Oct 18, 2023
e4ea73e
My Account: Cleaned-up/reorganised user header dropdown
ssddanbrown Oct 18, 2023
cf72e48
User form: Always show external auth field, update access control
ssddanbrown Oct 19, 2023
f9422df
My Account: Added self-delete flow
ssddanbrown Oct 19, 2023
1294641
API Tokens: Updated interfaces to return to correct location
ssddanbrown Oct 19, 2023
fabc854
My Account: Updated and started adding to tests
ssddanbrown Oct 19, 2023
f55e7ca
User Account: Ensured page titles for pages and api tokens
ssddanbrown Oct 19, 2023
ce53f64
My Account: Covered profile and auth pages with tests
ssddanbrown Oct 19, 2023
38fe408
Update SECURITY.md
radiantwave Oct 19, 2023
02bfaff
My Acount: Updated old preference url reference for watches
ssddanbrown Oct 19, 2023
995b7d6
Merge pull request #4615 from BookStackApp/user_account
ssddanbrown Oct 19, 2023
c513cda
Merge pull request #4618 from radiantwave/patch-1
ssddanbrown Oct 19, 2023
f5756ff
Security: Swapped twitter for mastodon link
ssddanbrown Oct 19, 2023
8375d34
Deps: Updated npm and composer packages
ssddanbrown Oct 20, 2023
d42af4a
Shortcuts: Prevented help shown when in inputs
ssddanbrown Oct 23, 2023
9b4f1fb
Styles: Aligned empty state alignment & consistency
ssddanbrown Oct 23, 2023
7c4dc98
Middlware: Prevented caching of all app requests
ssddanbrown Oct 23, 2023
8bffceb
Updated translations with latest Crowdin changes (#4523)
ssddanbrown Oct 30, 2023
e006f96
Langs: Updated translators and locale list pre v23.10
ssddanbrown Oct 30, 2023
49b286c
Demo mode: Updated my account access to be more selective
ssddanbrown Oct 30, 2023
5b45eac
Merge branch 'development' into release
ssddanbrown Oct 30, 2023
7e44b19
Updated version and assets for release v23.10
ssddanbrown Oct 30, 2023
c640db8
Readme: Updated sponsorship links and language contribution info
ssddanbrown Oct 30, 2023
fce7190
Testing: Added PHP8.3 support
ssddanbrown Oct 31, 2023
324e403
JS Events: Added CM pre/post init events
ssddanbrown Nov 1, 2023
38ac3c9
Page JS: Improved block jumping and highlighting
ssddanbrown Nov 1, 2023
02d1401
Editor toolbox: Updated tabs to use link color
ssddanbrown Nov 2, 2023
9dd05b8
MD Editor: Fixed lack of toolbar BG when in fullscreen
ssddanbrown Nov 2, 2023
48bda11
Langs: Enabled Nynorsk option, updated translator attribution
ssddanbrown Nov 2, 2023
889b0da
Updated translations with latest Crowdin changes (#4631)
ssddanbrown Nov 2, 2023
72521d0
Merge branch 'development' into release
ssddanbrown Nov 2, 2023
c61af9c
Updated version and assets for release v23.10.1
ssddanbrown Nov 2, 2023
ea0469e
PWA: Prevent passing credentials to avoid redirection issues
ssddanbrown Nov 7, 2023
1310db1
Updated translations with latest Crowdin changes (#4643)
ssddanbrown Nov 7, 2023
fa6ac21
Dropdowns: Fixed bad direction logic, added dynmaic height
ssddanbrown Nov 7, 2023
6cd38a8
Merge branch 'development' of github.com:BookStackApp/BookStack into …
ssddanbrown Nov 7, 2023
48f1152
Updated translator attribution before release v23.10.2
ssddanbrown Nov 7, 2023
4626278
Merge branch 'development' into release
ssddanbrown Nov 7, 2023
d8383cf
Updated version and assets for release v23.10.2
ssddanbrown Nov 7, 2023
bff1f50
JS: Removed random extra import
ssddanbrown Nov 9, 2023
2fb873f
Favicon: Moved resizing to specific resizer class
ssddanbrown Nov 19, 2023
9b1f820
Images: Forced intervention loading via specific method
ssddanbrown Nov 19, 2023
15d7161
Images: Prevented base64 extraction without permission
ssddanbrown Nov 20, 2023
8744eb2
Merge branch 'v23-10' into release
ssddanbrown Nov 20, 2023
5d08f7c
Updated version and assets for release v23.10.4
ssddanbrown Nov 20, 2023
61ed38f
Merge branch 'vatger' into release
paulhollmann Dec 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions resources/js/components/page-comments.js
Original file line number Diff line number Diff line change
@@ -27,16 +27,12 @@ export class PageComments extends Component {

// Internal State
this.parentId = null;
this.formReplyText = this.formReplyLink.textContent;
this.formReplyText = this.formReplyLink?.textContent || '';

this.setupListeners();
}

setupListeners() {
this.removeReplyToButton.addEventListener('click', this.removeReplyTo.bind(this));
this.hideFormButton.addEventListener('click', this.hideForm.bind(this));
this.addCommentButton.addEventListener('click', this.showForm.bind(this));

this.elem.addEventListener('page-comment-delete', () => {
this.updateCount();
this.hideForm();
@@ -47,6 +43,9 @@ export class PageComments extends Component {
});

if (this.form) {
this.removeReplyToButton.addEventListener('click', this.removeReplyTo.bind(this));
this.hideFormButton.addEventListener('click', this.hideForm.bind(this));
this.addCommentButton.addEventListener('click', this.showForm.bind(this));
this.form.addEventListener('submit', this.saveComment.bind(this));
}
}
@@ -123,9 +122,8 @@ export class PageComments extends Component {
this.showForm();
this.parentId = commentLocalId;
this.replyToRow.toggleAttribute('hidden', false);
const replyLink = this.replyToRow.querySelector('a');
replyLink.textContent = this.formReplyText.replace('1234', this.parentId);
replyLink.href = `#comment${this.parentId}`;
this.formReplyLink.textContent = this.formReplyText.replace('1234', this.parentId);
this.formReplyLink.href = `#comment${this.parentId}`;
}

removeReplyTo() {