Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: enable @typescripteslint/array-type #36

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

LoTwT
Copy link
Contributor

@LoTwT LoTwT commented Nov 20, 2024

description

@typescripteslint/array-type is an eslint rule to unify the array type styles.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b680f1) to head (daf9230).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines          649       649           
  Branches       137       137           
=========================================
  Hits           649       649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chouchouji
Copy link
Member

Thanks for your contribution.

The rule of this eslint plugin is
image

So for union type, Array is better T

image

@chouchouji
Copy link
Member

I think you can check this eslint plugin docs and update code. Thanks again.

@LoTwT
Copy link
Contributor Author

LoTwT commented Nov 20, 2024

🤣 I enable this rule, but indeed, the final preferred style isn't decided by me.

♥️ From #31, @haoziqaq didn't show his preferred style, and @chouchouji you prefer array-simple. So We can wait for @haoziqaq's choice.

@chouchouji
Copy link
Member

🤣 I enable this rule, but indeed, the final preferred style isn't decided by me.

♥️ From #31, @haoziqaq didn't show his preferred style, and @chouchouji you prefer array-simple. So We can wait for @haoziqaq's choice.

I think the default behavior of this eslint plugin is better.
image

@haoziqaq haoziqaq merged commit e695f25 into varletjs:dev Nov 20, 2024
3 checks passed
@LoTwT LoTwT deleted the array-type branch November 20, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants