Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/translation EN > ES jwt.es.md file #1036

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TheHandyOwl
Copy link
Contributor

NEW: translation EN (current jwt.md file) to ES (new jwt.es.md file)

@TheHandyOwl TheHandyOwl requested review from a team, 0xTim and gwynne as code owners December 14, 2024 23:11
@TheHandyOwl TheHandyOwl added the translation-update This PR contains translations for the docs label Dec 14, 2024
@TheHandyOwl TheHandyOwl self-assigned this Dec 14, 2024
@TheHandyOwl
Copy link
Contributor Author

TheHandyOwl commented Dec 14, 2024

@0xTim , @gwynne , should this HMAC options be 256, 384 and 512?
I can create another pull request to change this option for all languages.

### HMAC

HMAC (Hash-based Message Authentication Code) is a symmetric algorithm that uses a secret key to sign and verify the JWT. Vapor supports the following HMAC algorithms:

- `HS256`: HMAC with SHA-256
- `HS384`: HMAC with SHA-384
- `HS384`: HMAC with SHA-384 // Should be `HS512`: HMAC with SHA-512?

@alemohamad
Copy link
Member

Good catch @TheHandyOwl ! In my opinion, we should add the fix in other languages in this PR.

@0xTim @gwynne what do you think?

@0xTim
Copy link
Member

0xTim commented Dec 17, 2024

Yep lets do it as part of this PR since it's related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation-update This PR contains translations for the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants