-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building/deployment of Python package and docker image #86
Merged
rossbar
merged 10 commits into
vanvalenlab:master
from
rossbar:ci/pin-python-deploy-workflow
Jan 26, 2024
Merged
Fix building/deployment of Python package and docker image #86
rossbar
merged 10 commits into
vanvalenlab:master
from
rossbar:ci/pin-python-deploy-workflow
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix failing deploy jobs due to missing setuptools.
4e599e8
to
ae2eccb
Compare
Has to be updated to at least 0.12.7 so that the new fetch_data utils are available.
Required for the fetch_data API.
rossbar
commented
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly ready to go and should fix (or at least go a significant way towards fixing) the deployment issues. Just one double-check about version requirements - assuming that's okay I'll go ahead and merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix failing deploy jobs due to missing setuptools.