Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update colors of transaction feed and points history icons #6450

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kathaypacific
Copy link
Collaborator

Description

This is planned for the transaction feed work but it also affects beefy, so I thought I'd just do it now. Kayla confirmed she is confident that she wants to go through with these changes (they're also in the demo designs) - rationale being taking away some color will bring more emphasis to the network icons.

Test plan

Simulator Screenshot - iPhone 15 Pro - 2025-01-24 at 16 54 16
Simulator Screenshot - iPhone 15 Pro - 2025-01-24 at 16 52 59

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (ed4ee81) to head (0187172).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   89.12%   89.11%   -0.02%     
==========================================
  Files         733      733              
  Lines       31909    31904       -5     
  Branches     6098     5783     -315     
==========================================
- Hits        28439    28430       -9     
- Misses       3275     3427     +152     
+ Partials      195       47     -148     
Files with missing lines Coverage Δ
src/components/ContactCircle.tsx 100.00% <100.00%> (ø)
src/icons/Activity.tsx 100.00% <100.00%> (ø)
src/icons/MagicWand.tsx 100.00% <100.00%> (ø)
src/points/cardDefinitions.tsx 76.27% <ø> (ø)
src/transactions/feed/TransactionFeedItemImage.tsx 95.91% <ø> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4ee81...0187172. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant