Assert network bytes out for replication slot stat computation is only allowed on primary #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y allowed on primary Signed-off-by: Harkrishn Patro <[email protected]>
|
Or maybe we can do an early exit if it's not a primary. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #847 +/- ##
============================================
+ Coverage 70.35% 70.39% +0.03%
============================================
Files 112 112
Lines 61467 61468 +1
============================================
+ Hits 43248 43272 +24
+ Misses 18219 18196 -23
|
madolson
approved these changes
Aug 7, 2024
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…y allowed on primary (valkey-io#847) Added an assertion to avoid incorrect usage of the network bytes out for replication code flow in slot stats computation. Signed-off-by: Harkrishn Patro <[email protected]> Signed-off-by: mwish <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
…y allowed on primary (#847) Added an assertion to avoid incorrect usage of the network bytes out for replication code flow in slot stats computation. Signed-off-by: Harkrishn Patro <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
…y allowed on primary (#847) Added an assertion to avoid incorrect usage of the network bytes out for replication code flow in slot stats computation. Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an assertion to avoid incorrect usage of the network bytes out for replication code flow in slot stats computation.