Enabling TLS Certificate rotation #1670
Open
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to build and test this locally? It looks like you are adding some new fields but they are never getting checked. Would you also mind explaining the issue in a little bit more detail? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1670 +/- ##
============================================
+ Coverage 70.98% 71.04% +0.06%
============================================
Files 121 121
Lines 65225 65243 +18
============================================
+ Hits 46299 46352 +53
+ Misses 18926 18891 -35
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where TLS certificate rotation was not working correctly by properly setting last_modified_time in the Valkey code. With this fix, Valkey correctly detects certificate updates, ensuring that the latest TLS certificates are used as expected.