Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opaque robj: add get/set methods and remove all robj->ptr refs #1658

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

add objectSetVal, remove remaining robj->ptr references outside of ob…

5b5de16
Select commit
Loading
Failed to load commit list.
Open

Opaque robj: add get/set methods and remove all robj->ptr refs #1658

add objectSetVal, remove remaining robj->ptr references outside of ob…
5b5de16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 0s

71.01% (-0.02%) compared to 78bcc0a, passed because coverage increased by 0.21% when compared to adjusted base (70.80%)

View this Pull Request on Codecov

71.01% (-0.02%) compared to 78bcc0a, passed because coverage increased by 0.21% when compared to adjusted base (70.80%)

Details

Codecov Report

Attention: Patch coverage is 84.02226% with 201 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (78bcc0a) to head (5b5de16).
Report is 5 commits behind head on unstable.

Files with missing lines Patch % Lines
src/sentinel.c 0.00% 73 Missing ⚠️
src/module.c 1.88% 52 Missing ⚠️
src/debug.c 78.26% 20 Missing ⚠️
src/object.c 84.52% 13 Missing ⚠️
src/rdb.c 94.44% 5 Missing ⚠️
src/t_list.c 91.22% 5 Missing ⚠️
src/cluster_legacy.c 88.23% 4 Missing ⚠️
src/replication.c 89.74% 4 Missing ⚠️
src/t_stream.c 94.44% 4 Missing ⚠️
src/db.c 95.89% 3 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1658      +/-   ##
============================================
- Coverage     71.02%   71.01%   -0.02%     
============================================
  Files           121      121              
  Lines         65176    65218      +42     
============================================
+ Hits          46290    46313      +23     
- Misses        18886    18905      +19     
Files with missing lines Coverage Δ
src/bitops.c 93.77% <100.00%> (+0.30%) ⬆️
src/cluster_slot_stats.c 94.35% <100.00%> (ø)
src/commandlog.c 96.58% <100.00%> (ø)
src/config.c 78.40% <100.00%> (+0.01%) ⬆️
src/eval.c 57.06% <100.00%> (ø)
src/expire.c 96.59% <100.00%> (ø)
src/functions.c 94.50% <100.00%> (ø)
src/geo.c 93.58% <100.00%> (ø)
src/latency.c 81.21% <100.00%> (+0.29%) ⬆️
src/lazyfree.c 86.11% <100.00%> (ø)
... and 32 more

... and 7 files with indirect coverage changes