Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Open
wants to merge 16 commits into
base: unstable
Choose a base branch
from

Merge branch 'valkey-io:unstable' into unstable

a071443
Select commit
Loading
Failed to load commit list.
Open

Refactor syncWithPrimary and replicaTryPartialResynchronization #1476

Merge branch 'valkey-io:unstable' into unstable
a071443
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 26, 2024 in 1s

70.85% (-0.02%) compared to 9f4503c, passed because coverage increased by 0.01% when compared to adjusted base (70.84%)

View this Pull Request on Codecov

70.85% (-0.02%) compared to 9f4503c, passed because coverage increased by 0.01% when compared to adjusted base (70.84%)

Details

Codecov Report

Attention: Patch coverage is 86.98630% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.85%. Comparing base (9f4503c) to head (a071443).
Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
src/replication.c 86.98% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1476      +/-   ##
============================================
- Coverage     70.86%   70.85%   -0.02%     
============================================
  Files           119      119              
  Lines         64859    64882      +23     
============================================
+ Hits          45963    45972       +9     
- Misses        18896    18910      +14     
Files with missing lines Coverage Δ
src/replication.c 87.60% <86.98%> (+0.07%) ⬆️

... and 11 files with indirect coverage changes