Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger manual failover on SIGTERM / shutdown to cluster primary #1091

Open
wants to merge 18 commits into
base: unstable
Choose a base branch
from

code review: remove error reply check, add cross-version test

7d55db6
Select commit
Loading
Failed to load commit list.
Open

Trigger manual failover on SIGTERM / shutdown to cluster primary #1091

code review: remove error reply check, add cross-version test
7d55db6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2025 in 0s

70.88% (-0.13%) compared to c75e866

View this Pull Request on Codecov

70.88% (-0.13%) compared to c75e866

Details

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.88%. Comparing base (c75e866) to head (7d55db6).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/cluster_legacy.c 94.73% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1091      +/-   ##
============================================
- Coverage     71.00%   70.88%   -0.13%     
============================================
  Files           121      121              
  Lines         65249    65296      +47     
============================================
- Hits          46329    46282      -47     
- Misses        18920    19014      +94     
Files with missing lines Coverage Δ
src/config.c 78.39% <ø> (ø)
src/replication.c 87.32% <100.00%> (+<0.01%) ⬆️
src/server.c 87.64% <100.00%> (ø)
src/server.h 100.00% <ø> (ø)
src/cluster_legacy.c 86.38% <94.73%> (+0.51%) ⬆️

... and 8 files with indirect coverage changes