Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add command XRange and XRevRange #2989

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Go: Add command XRange and XRevRange #2989

merged 6 commits into from
Jan 24, 2025

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Jan 22, 2025 •
edited by yipin-chen
Loading

Issue link

This Pull Request is linked to issue (URL): #2881, #2969

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ added the go golang wrapper label Jan 22, 2025
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner January 22, 2025 02:19
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 22, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Outdated Show resolved Hide resolved
go/api/response_handlers.go Outdated Show resolved Hide resolved
This was referenced Jan 22, 2025
Closed
Open
Yury-Fridlyand
Yury-Fridlyand approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need a decision for options

jbrinkman
jbrinkman reviewed Jan 23, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Show resolved Hide resolved
go/api/base_client.go Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 23, 2025
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
update examples
5a7ccff 
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ merged commit a8d4b16 into main Jan 24, 2025
17 of 18 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-xrange branch January 24, 2025 02:51
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 24, 2025
@tjzhang-BQ @EdricCua
Go: Add command XRange and XRevRange (valkey-io#2989)
1ef51a9 
* Go: Add command XRange and XRevRange

Signed-off-by: TJ Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jbrinkman jbrinkman jbrinkman left review comments

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjzhang-BQ @jbrinkman @Yury-Fridlyand @yipin-chen @prateek-kumar-improving