Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Fix return types, part 6 #2965

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

Fix return types for commands which return arrays.
+ fix couple of comments left which return strings.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 16, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 16, 2025 23:55
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand merged commit b95fbbd into valkey-io:main Jan 20, 2025
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/fix-return-types-6 branch January 20, 2025 19:23
edlng pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jan 20, 2025
* Fix return types.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Maayanshani25 pushed a commit to Maayanshani25/valkey-glide that referenced this pull request Jan 22, 2025
* Fix return types.

Signed-off-by: Yury-Fridlyand <[email protected]>
eifrah-aws pushed a commit to eifrah-aws/glide-for-redis that referenced this pull request Jan 23, 2025
* Fix return types.

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants