Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Fix zrangeWithScores (disallow RangeByLex as it is not supported) #2926

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Node: Fix zrangeWithScores (disallow RangeByLex as it is not supported) #2926

merged 2 commits into from
Jan 9, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Jan 8, 2025 •
edited
Loading

Node: Fix zrangeWithScores (disallow RangeByLex as it is not supported)

> await client.zrangeWithScores("zz", { start: '-', end: '+', type: "byLex"})
2025-01-08T02:49:25.077335Z  WARN logger_core: received error - An error was signalled by the server - ResponseError: syntax error, WITHSCORES not supported in combination with BYLEX
Uncaught:
RequestError: An error was signalled by the server - ResponseError: syntax error, WITHSCORES not supported in combination with BYLEX
    at GlideClient.processResponse (node/build-ts/src/BaseClient.js:337:20)
    at GlideClient.handleReadData (node/build-ts/src/BaseClient.js:322:22)

@Yury-Fridlyand
Fix zrangeWithScores.
4af4dfd 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Jan 8, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 8, 2025 02:57
@Yury-Fridlyand
Copy link
Collaborator Author

Other clients don't need such fix.

tjzhang-BQ
tjzhang-BQ approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yury-Fridlyand Yury-Fridlyand merged commit 4334c54 into valkey-io:main Jan 9, 2025
19 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/fix-zrange branch January 9, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @tjzhang-BQ @yipin-chen