Rust - code cleanup, part 1

[avifenesh]

This pull request includes various changes across multiple files to improve code readability, update configurations, and remove deprecated methods.

Configuration Updates:

• .vscode/settings.json: Updated the path for redis-rs/Cargo.toml and added new settings for makefile and rust-analyzer. [1] [2]

Dependency and Feature Formatting:

• glide-core/Cargo.toml: Reformatted dependency and feature lists for better readability. [1] [2]
• glide-core/redis-rs/redis/Cargo.toml: Reformatted feature lists and added new metadata. [1] [2] [3]

Code Refactoring:

• glide-core/redis-rs/redis/src/aio/connection.rs: Removed the map method and refactored the connect function. [1] [2]
• glide-core/redis-rs/redis/src/client.rs: Removed deprecated async connection methods. [1] [2] [3]

Documentation and Testing:

• node/DEVELOPER.md: Updated the steps for building and testing the Node wrapper. [1] [2] [3]
• node/tests/SharedTests.ts: Replaced deep equality to deep close check with expect.arrayContaining and expect.closeTo for handling precision diff in floats.

Additional Changes:

• glide-core/redis-rs/redis/src/cluster_async/connections_logic.rs: Replaced custom timeout logic with tokio::time::timeout. [1] [2]
• glide-core/redis-rs/redis/src/types.rs: Added a conversion from tokio::time::error::Elapsed to RedisError.

Please make sure you are aware of our contributing guidelines available
here

Issue link

This Pull Request is linked to issue: [#2450 ]

Checklist

Before submitting the PR make sure the following are checked:

• [v ] This Pull Request is related to one issue.
• [ v] Commit message has a detailed description of what changed and why.
• [v ] Tests are added or updated.
• [v ] CHANGELOG.md and documentation files are updated.
• [v ] Destination branch is correct - main or release
• [ v] Commits will be squashed upon merging.

[eifrah-aws]

IMO, this file should not be kept in the respository

[avifenesh]

You're right, but for old reasons it's on the part and I don't want to break any one work by completely remove it.
The specific line here is needed for analyzer to understand how to read complicated monorepo, and many had tackle the issue, so we added a shared solution.

[jamesx-improving]

If this file is still being maintained at all, can we please consider to remove all the OnSave settings in it? Currently, I'm using:

git update-index --skip-worktree .vscode/settings.json

to prevent the OnSave setting to be reverted to on every time I pull or switch branches, as not only it is in the git repo, but the entire .vscode folder is also in .gitignore, making any change you made ignored by git.

[avifenesh]

If it's not break anything to remove it, we should.
But it will affect a lot of us, so I think we should be careful with it.
Try to remove it and see the effect, and if no effect we can try in a few other WS and see if it is feasible to remove and not break everyone's WS. I'd be happy if we got rid of it, each can use his config.

[Yury-Fridlyand]

Please rename the PR and add changelog

[Yury-Fridlyand]

Fix this for all clients please

[avifenesh]

Please rename the PR and add changelog

What do you mean by rename pr?

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

[Yury-Fridlyand]

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi. CI changes have no effect for user too, but we list them there.

[avifenesh]

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi. CI changes have no effect for user too, but we list them there.

Yes my question is on CI as well, are we want to include it in release note? Im not sure its relevant
I'll check