Some cleaning for unnecessary code to set the floor for next PR #2477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across multiple files to improve code readability, update configurations, and remove deprecated methods.
Configuration Updates:
.vscode/settings.json
: Updated the path forredis-rs/Cargo.toml
and added new settings formakefile
andrust-analyzer
. [1] [2]Dependency and Feature Formatting:
glide-core/Cargo.toml
: Reformatted dependency and feature lists for better readability. [1] [2]glide-core/redis-rs/redis/Cargo.toml
: Reformatted feature lists and added new metadata. [1] [2] [3]Code Refactoring:
glide-core/redis-rs/redis/src/aio/connection.rs
: Removed themap
method and refactored theconnect
function. [1] [2]glide-core/redis-rs/redis/src/client.rs
: Removed deprecated async connection methods. [1] [2] [3]Documentation and Testing:
node/DEVELOPER.md
: Updated the steps for building and testing the Node wrapper. [1] [2] [3]node/tests/SharedTests.ts
: Replaced deep equality to deep close check withexpect.arrayContaining
andexpect.closeTo
for handling precision diff in floats.Additional Changes:
glide-core/redis-rs/redis/src/cluster_async/connections_logic.rs
: Replaced custom timeout logic withtokio::time::timeout
. [1] [2]glide-core/redis-rs/redis/src/types.rs
: Added a conversion fromtokio::time::error::Elapsed
toRedisError
.Please make sure you are aware of our contributing guidelines available
here
Issue link
This Pull Request is linked to issue: [#2450 ]
Checklist
Before submitting the PR make sure the following are checked: