Update CONTRIBUTING.md to match PR guidelines #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/models/configuration/BaseClientConfiguration.java
Outdated
Show resolved
Hide resolved
acarbonetto
force-pushed
the
docs/update_release_process
branch
from
fe64eb8 to
3003fe1
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
docs/update_release_process
branch
from
3003fe1 to
6c65658
Compare
ikolomi
requested changes
Oct 11, 2024
I'm not sure why you are saying this. Is this because we should not be backporting changes to This is a crucial reminder now that we have added version/release branches and these changes are blocking development. |
|
Will remove pr changes, and have raised #2441 to discuss way forward and make sure we don't forget to backport changes from release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2422
Follows: #2411
Checklist
Before submitting the PR make sure the following are checked: