Add all module commands to proto #2389
Conversation
| @@ -21,7 +21,7 @@ def test_encode_decode_delimited(self): | |||
| b_arr = bytearray() | |||
| ProtobufCodec.encode_delimited(b_arr, request) | |||
| msg_len_varint = int(b_arr[0]) | |||
| assert msg_len_varint == 18 | |||
| assert msg_len_varint == 19 | |||
There was a problem hiding this comment.
Small question:
What is the context around this change?
There was a problem hiding this comment.
Very good question actually. Get/set commands used in this test got bigger numbers and now require more bytes to encode that.
| Watch = 1605, | ||
|
|
||
| //// JSON commands | ||
| JsonArrAppend = 2001, |
There was a problem hiding this comment.
I think we should split this PR into two:
- clean up all the existing commands
- add the JSON and VSS commands
|
|
||
| //// JSON commands | ||
|
|
||
| JsonArrAppend = 2001; |
There was a problem hiding this comment.
I think we should split this PR into two:
- clean up all the existing commands
- add the JSON and VSS commands
There was a problem hiding this comment.
what do you mean in cleanup?
There was a problem hiding this comment.
refactor? move the enums? Cleanup?
There was a problem hiding this comment.
I just copy-pasted Very Big Enum into multiple places and fixed two broken refs (they were named incorrectly).
|
my honest question is just why 😐 |
We won't have merge conflicts in every PR if we add this now. |
|
@Yury-Fridlyand No! why such a massive change ? What issue? Why do we need it? |
|
It isn't massive, but we have 1 enum repeated 4 times. |
|
|
||
| //// Vector Search commands | ||
|
|
||
| FtList = 2101; |
There was a problem hiding this comment.
someone might ask why this command is out of order with the rest of the commands XD
acarbonetto
changed the title
No description provided.