Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Set commands #2373

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Go: Implement Set commands #2373

merged 7 commits into from
Oct 14, 2024

Conversation

umit
Copy link
Collaborator

@umit umit commented Sep 30, 2024

This PR introduces the SetCommands interface to the Valkey client, implementing essential set operations.

New interface methods:

  1. SAdd
  2. SRem
  3. SMembers
  4. SCard
  5. SIsMember
  6. SDiff
  7. SDiffStore
  8. SInter
  9. SInterCard
  10. SInterCardLimit
  11. SRandMember
  12. SPop

Key changes:

  • Added SetCommands interface with 12 methods for set operations
  • Each method includes documentation with parameters, return values, and usage examples
  • Added unit tests for each method to ensure correct functionality

@umit umit requested a review from a team as a code owner September 30, 2024 16:57
janhavigupta007
janhavigupta007 requested changes Oct 1, 2024
View reviewed changes
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/commands.go Outdated Show resolved Hide resolved
go/integTest/shared_commands_test.go Show resolved Hide resolved
go/src/lib.rs Show resolved Hide resolved
janhavigupta007
janhavigupta007 reviewed Oct 1, 2024
View reviewed changes
go/api/commands.go Outdated Show resolved Hide resolved
@janhavigupta007 janhavigupta007 added the go golang wrapper label Oct 1, 2024
@umit umit force-pushed the go/set-commands-implementation branch 2 times, most recently from 30b4e6c to 351e1fd Compare October 1, 2024 17:28
@umit umit requested a review from janhavigupta007 October 1, 2024 17:54
Yury-Fridlyand
Yury-Fridlyand reviewed Oct 1, 2024
View reviewed changes
go/integTest/glide_test_suite_test.go Outdated Show resolved Hide resolved
go/src/lib.rs Show resolved Hide resolved
@umit umit force-pushed the go/set-commands-implementation branch 3 times, most recently from 9a1735c to e5e44f2 Compare October 4, 2024 05:55
@umit umit requested a review from Yury-Fridlyand October 5, 2024 11:40
@umit umit force-pushed the go/set-commands-implementation branch from e5e44f2 to 7e949bb Compare October 7, 2024 17:15
Yury-Fridlyand
Yury-Fridlyand approved these changes Oct 8, 2024
View reviewed changes
go/src/lib.rs Show resolved Hide resolved
go/integTest/glide_test_suite_test.go Show resolved Hide resolved
janhavigupta007
janhavigupta007 reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@janhavigupta007 janhavigupta007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a separate type for Sets as it is handled separately in GO.

eifrah-aws
eifrah-aws reviewed Oct 10, 2024
View reviewed changes
go/src/lib.rs Show resolved Hide resolved
go/src/lib.rs Show resolved Hide resolved
@umit umit force-pushed the go/set-commands-implementation branch from 7e949bb to c6b21fc Compare October 10, 2024 16:20
umit added 6 commits October 11, 2024 08:57
@umit
Go: Implement Set commands
d9d7594 
Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>

# Conflicts:
#	go/api/base_client.go

# Conflicts:
#	go/api/base_client.go
#	go/integTest/shared_commands_test.go
@umit
Add SkipIfServerVersionLowerThan7 function
b832546 
Signed-off-by: umit <[email protected]>
@umit
Update SInterCardLimit function
fb6df70 
Signed-off-by: umit <[email protected]>
@umit
Add version parameter to SkipIfServerVersionLowerThanBy
9338502 
Signed-off-by: umit <[email protected]>
@umit
Remove set type
077a343 
Signed-off-by: umit <[email protected]>
@umit
Fix handle Set type
17008db 
Signed-off-by: umit <[email protected]>
@umit umit force-pushed the go/set-commands-implementation branch from c6b21fc to 83be607 Compare October 11, 2024 15:53
@umit umit requested a review from janhavigupta007 October 11, 2024 15:55
@umit umit force-pushed the go/set-commands-implementation branch from 83be607 to f60d85c Compare October 12, 2024 18:29
janhavigupta007
janhavigupta007 approved these changes Oct 14, 2024
View reviewed changes
go/api/set_command.go Outdated Show resolved Hide resolved
@umit umit force-pushed the go/set-commands-implementation branch from f60d85c to 8001ee8 Compare October 14, 2024 14:23
@umit umit merged commit b0d39ed into valkey-io:main Oct 14, 2024
13 checks passed
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 18, 2024
@umit @avifenesh
Go: Implement Set commands (valkey-io#2373)
43bcf39 
Go: Implement Set commands

Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 21, 2024
@umit @BoazBD
Go: Implement Set commands (valkey-io#2373)
7601e2e 
Go: Implement Set commands

Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 21, 2024
@umit @BoazBD
Go: Implement Set commands (valkey-io#2373)
19fb66d 
Go: Implement Set commands

Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>
Muhammad-awawdi-amazon pushed a commit that referenced this pull request Oct 23, 2024
@umit @Muhammad-awawdi-amazon
Go: Implement Set commands (#2373)
f4b415f 
Go: Implement Set commands

Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>
acarbonetto pushed a commit that referenced this pull request Nov 5, 2024
@umit @acarbonetto
Go: Implement Set commands (#2373)
705dba3 
Go: Implement Set commands

Add SetCommands interface with methods:
SAdd, SRem, SMembers, SCard, SIsMember, SDiff, SDiffStore,
SInter, SInterCard, SInterCardLimit, SRandMember, SPop

- Include method documentation and usage examples
- Add unit tests for all new methods

Signed-off-by: umit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eifrah-aws eifrah-aws eifrah-aws left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@ravisi21 ravisi21 ravisi21 approved these changes

@MikeMwita MikeMwita MikeMwita approved these changes

@janhavigupta007 janhavigupta007 janhavigupta007 approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@umit @janhavigupta007 @Yury-Fridlyand @MikeMwita @eifrah-aws @ravisi21