Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce glide_rs.so size (for Java) #2367

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

eifrah-aws
Copy link
Contributor

@eifrah-aws eifrah-aws commented Sep 29, 2024

This PR strips debugging symbols from the compiled Rust shared object (libglide_rs.so)
and reduces its size from 59MB down to 4.4MB

Closes: #2039

Before:

$ ls -lh ./target/release/deps/libglide_rs.so
-rwxrwxr-x 2 ubuntu ubuntu 59M Sep 29 11:15 ./target/release/deps/libglide_rs.so

After:

$ ls -lh ./target/release/deps/libglide_rs.so
-rwxrwxr-x 2 ubuntu ubuntu 4.4M Sep 29 11:51 ./target/release/deps/libglide_rs.so

@eifrah-aws eifrah-aws requested a review from a team as a code owner September 29, 2024 11:59
@eifrah-aws eifrah-aws merged commit 22a2cee into valkey-io:main Sep 30, 2024
13 checks passed
umit pushed a commit to umit/valkey-glide that referenced this pull request Oct 1, 2024
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Oct 1, 2024
@Yury-Fridlyand
Copy link
Collaborator

Thanks!
You're missing a changelog entry

@eifrah-aws eifrah-aws deleted the java-reduce-strip-symbols branch November 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cargo toml add release profile ( --release --strip)
3 participants