Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: move pubsub IT to another suite #2352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java: move pubsub IT to another suite #2352

wants to merge 2 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

Now ./gradlew build and ./gradlew :integTest:test don't include pubsub IT.
To run it do ./gradlew :integTest:pubsubTest

@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client testing Everything about testing labels Sep 24, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 24, 2024 23:41
acarbonetto
acarbonetto reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are pubsub tests being removed from IT?

@Yury-Fridlyand
Copy link
Collaborator Author

I like how they are split in python client. Those test also take a lot of time and I wanted to avoid dull increasing CI timeouts. Later we may want to run CI for pubsub independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
java issues and fixes related to the java client testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @acarbonetto