Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add HSCAN #2098

Merged
merged 37 commits into from
Aug 12, 2024
Merged

Node: add HSCAN #2098

merged 37 commits into from
Aug 12, 2024

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Aug 7, 2024

No description provided.

@cyip10 cyip10 added the node Node.js wrapper label Aug 7, 2024
@cyip10 cyip10 force-pushed the node/integ_cyip10_hscan branch from 2b1bb0d to e4f096a Compare August 7, 2024 18:16
@cyip10 cyip10 marked this pull request as ready for review August 8, 2024 16:48
@cyip10 cyip10 requested a review from a team as a code owner August 8, 2024 16:48
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
@cyip10 cyip10 force-pushed the node/integ_cyip10_hscan branch from 7683c0d to 29a0117 Compare August 8, 2024 21:00
* @param key - The key of the set.
* @param cursor - The cursor that points to the next iteration of results. A value of `"0"` indicates the start of the search.
* @param options - The {@link BaseScanOptions}.
* @returns An array of the `cursor` and the subset of the hash held by `key`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can keep only the first phrase and add "see example for more details"? I did this in some commands.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should decide this as a team if we want to follow this convention, but i also don't mind shortening it down

node/src/Commands.ts Outdated Show resolved Hide resolved
@cyip10 cyip10 force-pushed the node/integ_cyip10_hscan branch from 320c979 to 772356f Compare August 9, 2024 22:23
cyip10 and others added 22 commits August 12, 2024 09:21
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Added XGROUP CREATE and XGROUP DESTROY commands

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: ort-bot <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `GEOSEARCHSTORE` command.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `XCLAIM` command.

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `FUNCTION STATS` command.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Node: add SRANDMEMBER command

---------

Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `HRANDFIELD` command.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
* Node: added APPEND command

Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Node: add command BZPOPMAX & BZPOPMIN

Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `XINFO CONSUMERS` command.

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Node: Add XINFO STREAM command

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Yury-Fridlyand and others added 9 commits August 12, 2024 09:22
Fix IT.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add Scala and Kotlin examples

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
…alkey-io#2088)

* Added XGROUP CREATE and XGROUP DESTROY commands

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Node: Add ZRANGESTORE command

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Node: added MOVE command

Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
* Add `XPENDING` command.

Signed-off-by: Yury-Fridlyand <[email protected]>
@cyip10 cyip10 force-pushed the node/integ_cyip10_hscan branch from 5046138 to 8ca6681 Compare August 12, 2024 16:23
node/src/Commands.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
cyip10 added 2 commits August 12, 2024 12:11
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When your PR is ready for merge, please squash and remove all commit history before the merge.

Signed-off-by: Chloe Yip <[email protected]>
@cyip10 cyip10 merged commit dcd31b9 into valkey-io:main Aug 12, 2024
8 checks passed
@cyip10 cyip10 deleted the node/integ_cyip10_hscan branch August 12, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants