Skip to content

Commit

Permalink
Fixed merged issues
Browse files Browse the repository at this point in the history
Signed-off-by: barshaul <[email protected]>
  • Loading branch information
barshaul committed Nov 14, 2024
1 parent 9da21fd commit 68e7fa4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 1 addition & 3 deletions glide-core/redis-rs/redis/src/cluster_async/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1969,8 +1969,6 @@ where
}

/// Handles MOVED errors by updating the client's slot and node mappings based on the new primary's role:
/// /// Updates the slot and node mappings in response to a MOVED error.
/// This function handles various scenarios based on the new primary's role:
///
/// 1. **No Change**: If the new primary is already the current slot owner, no updates are needed.
/// 2. **Failover**: If the new primary is a replica within the same shard (indicating a failover),
Expand Down Expand Up @@ -2550,7 +2548,7 @@ where
if let Some(future) = future {
self.in_flight_requests.push(Box::pin(Request {
retry_params,
request: Some(request),
request,
future,
}));
}
Expand Down
1 change: 0 additions & 1 deletion glide-core/redis-rs/redis/tests/auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ mod auth {
create_connection(None, ConnectionType::Cluster, Some(&cluster_context), None).await;
assert!(connection_should_fail.is_err());
let err = connection_should_fail.err().unwrap();
println!("{}", err.to_string());
assert!(err.to_string().contains("Authentication required."));

// Test that we can connect with password
Expand Down

0 comments on commit 68e7fa4

Please sign in to comment.