Skip to content

Commit

Permalink
Go: Fixing the version of staticcheck (#2463)
Browse files Browse the repository at this point in the history
* Go: Fixing the version of staticcheck

Signed-off-by: Janhavi Gupta <[email protected]>
  • Loading branch information
janhavigupta007 authored Oct 30, 2024
1 parent a7272ea commit 1f36355
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion go/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ install-dev-tools-go1.22:
go install github.com/vakenbolt/[email protected]
go install mvdan.cc/[email protected]
go install github.com/segmentio/[email protected]
go install honnef.co/go/tools/cmd/staticcheck@v0.4.6
go install honnef.co/go/tools/cmd/staticcheck@latest

install-dev-tools-go1.22.0: install-dev-tools-go1.22

Expand Down
2 changes: 1 addition & 1 deletion go/integTest/glide_test_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func runClusterManager(suite *GlideTestSuite, args []string, ignoreExitCode bool
suite.T().Fatalf("Unexpected error while executing cluster_manager.py: %s", err.Error())
}

if exitError.Stderr != nil && len(exitError.Stderr) > 0 {
if len(exitError.Stderr) > 0 {
suite.T().Logf("cluster_manager.py stderr:\n====\n%s\n====\n", string(exitError.Stderr))
}

Expand Down
4 changes: 4 additions & 0 deletions go/integTest/shared_commands_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,8 @@ func (suite *GlideTestSuite) TestAppend_existingAndNonExistingKeys() {
}

func (suite *GlideTestSuite) TestLCS_existingAndNonExistingKeys() {
suite.SkipIfServerVersionLowerThanBy("7.0.0")

suite.runWithDefaultClients(func(client api.BaseClient) {
key1 := "{key}" + uuid.New().String()
key2 := "{key}" + uuid.New().String()
Expand Down Expand Up @@ -1599,6 +1601,8 @@ func (suite *GlideTestSuite) TestSInterCard() {
}

func (suite *GlideTestSuite) TestSInterCardLimit() {
suite.SkipIfServerVersionLowerThanBy("7.0.0")

suite.runWithDefaultClients(func(client api.BaseClient) {
key1 := "{key}-1-" + uuid.NewString()
key2 := "{key}-2-" + uuid.NewString()
Expand Down

0 comments on commit 1f36355

Please sign in to comment.