common automatic update #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Sep 24, 2024
mbaldessari
commented
- Replace tabs with spaces and add some missing env vars that could be passed
- Also push any changes to operator-install to its own repo
- Update CRD from operator v0.0.55
- Fix chart name in pattern-install branch+split wf
- Tweak readme
- Use $group.name in clusterset metadata
- Expose originURL as helm value
- Update tests after common rebase
- Release clustergroup v0.8.13
- Release acm v0.1.2
- Drop schema required under the Main section
- Release clustergroup v0.8.14
- Update README for the v1 common branch
- Allow customizing the clusterGroupChartVersion
- Release pattern-install v0.0.2
- Drop the chart splitting workflows
- Make sure we compare lists with lists when doing a difference
Replace tabs with spaces and add some missing env vars that could be passed
Since at the time the folder was named operator-install and the chart pattern-install, let's push it out to the `pattern-install-chart` repo which is a bit clearer.
Also push any changes to operator-install to its own repo
Update CRD from operator v0.0.55
Fix chart name in pattern-install branch+split wf
Use $group.name in clusterset metadata
This is needed, this way when this variable is set we can actually detect that an in-cluster gitea instance has been set up.
Release clustergroup v0.8.13
Release acm chart 0.1.2
The "main" subsection of helm values is only used for kickstarting a pattern. It is entirely possible to only set one value and then set the other variables through other means (editing CRs e.g.). There is no point on blocking this.
Drop schema required under the Main section
❯ helm template . --show-only "templates/pattern.yaml"
---
apiVersion: gitops.hybrid-cloud-patterns.io/v1alpha1
kind: Pattern
metadata:
name: release-name
namespace: openshift-operators
spec:
clusterGroupName: default
gitSpec:
targetRepo: https://github.com/pattern-clone/mypattern
targetRevision: main
multiSourceConfig:
enabled: false
❯ helm template . --show-only "templates/pattern.yaml" --set main.multiSourceConfig.clusterGroupChartVersion=0.9.\*
---
apiVersion: gitops.hybrid-cloud-patterns.io/v1alpha1
kind: Pattern
metadata:
name: release-name
namespace: openshift-operators
spec:
clusterGroupName: default
gitSpec:
targetRepo: https://github.com/pattern-clone/mypattern
targetRevision: main
multiSourceConfig:
enabled: false
clusterGroupChartVersion: 0.9.*
They used to run only for the main branch and this is the v1 branch, but let's drop them anyway as they cause quite a bit of confusion.
…roupversion v1 operator install clustergroupversion
While this works with older ansible versions (2.15 and before), we need to check the difference between two lists and not a list and an item. This breaks with ansible 2.16 and onwards Tested with newer ansible and the vault now unseals correctly.
Make sure we compare lists with lists when doing a difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.