Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc workflow #985

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: doc workflow #985

merged 1 commit into from
Nov 16, 2023

Conversation

diegomrsantos
Copy link
Contributor

Use nim 1.6.x as nimble install_pinned does not work with nim 2.0.0 and nimble 0.14.2

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #985 (cf56a23) into unstable (ebef85c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           unstable     #985   +/-   ##
=========================================
  Coverage     83.20%   83.20%           
=========================================
  Files            91       91           
  Lines         15301    15301           
=========================================
  Hits          12731    12731           
  Misses         2570     2570           

@romanzac
Copy link
Collaborator

Looks alright to me. We don't have lock file working yet, nimble install_pinned is the option for now.
Is the documentation same when I generate it with Nim 1.6 or Nim 2.0 ?

@diegomrsantos diegomrsantos merged commit 5f7a3ab into unstable Nov 16, 2023
10 checks passed
@diegomrsantos diegomrsantos deleted the fix-doc-workflow branch November 16, 2023 14:58
romanzac pushed a commit that referenced this pull request Nov 30, 2023
dryajov pushed a commit that referenced this pull request Dec 4, 2023
romanzac pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants