Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chronos v4 compat #982

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix chronos v4 compat #982

merged 1 commit into from
Nov 16, 2023

Conversation

arnetheduck
Copy link
Contributor

This helps keep libp2p compatible with both chronos v3 and v4 while v4 is being developed (in particular status-im/nim-chronos#470)

This helps keep libp2p compatible with both chronos v3 and v4 while v4
is being developed
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #982 (98bfdfd) into unstable (ebef85c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #982      +/-   ##
============================================
- Coverage     83.20%   83.17%   -0.04%     
============================================
  Files            91       91              
  Lines         15301    15301              
============================================
- Hits          12731    12726       -5     
- Misses         2570     2575       +5     
Files Coverage Δ
libp2p/errors.nim 84.21% <100.00%> (ø)
libp2p/transports/tcptransport.nim 78.88% <100.00%> (ø)

... and 3 files with indirect coverage changes

@arnetheduck arnetheduck merged commit 4e7eaba into unstable Nov 16, 2023
9 of 10 checks passed
@arnetheduck arnetheduck deleted the chronos-v4-compat branch November 16, 2023 15:54
romanzac pushed a commit that referenced this pull request Nov 30, 2023
dryajov pushed a commit that referenced this pull request Dec 4, 2023
romanzac pushed a commit that referenced this pull request Dec 13, 2023
diegomrsantos pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants