Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactors to remove .closure., .gcsafe for .async. procs, and added callback compatibility to daemonapi #1240

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

richard-ramos
Copy link
Member

No description provided.

@richard-ramos richard-ramos requested a review from kaiserd January 24, 2025 13:51
@richard-ramos richard-ramos marked this pull request as ready for review January 24, 2025 13:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (c5aa373) to head (9dac37a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   84.58%   84.58%   -0.01%     
==========================================
  Files          93       93              
  Lines       16796    16800       +4     
==========================================
+ Hits        14207    14210       +3     
- Misses       2589     2590       +1     
Files with missing lines Coverage Δ
libp2p/nameresolving/dnsresolver.nim 66.39% <100.00%> (ø)
libp2p/protocols/pubsub/pubsub.nim 85.30% <100.00%> (+0.21%) ⬆️
libp2p/protocols/pubsub/pubsubpeer.nim 85.10% <ø> (ø)
libp2p/transports/quictransport.nim 84.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants