Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send priority with queue fix #1051

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Send priority with queue fix #1051

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f3e0e15
Reapply "feat: message prioritization with immediate peer-published d…
arnetheduck Mar 4, 2024
be1c07f
avoid redundant message copies
arnetheduck Mar 4, 2024
098da4d
handle errors in continuation
arnetheduck Mar 4, 2024
a507a91
handle error cases
arnetheduck Mar 4, 2024
afbc9fc
fickle timers
arnetheduck Mar 4, 2024
74ff130
create pubsubpeer-queue-metrics
diegomrsantos Feb 22, 2024
43d41f8
fix comment
arnetheduck Mar 4, 2024
26a37e3
fix missing value
arnetheduck Mar 4, 2024
e6cea07
Merge remote-tracking branch 'origin/unstable' into 1015-order
arnetheduck Mar 5, 2024
6eb23ca
revert asyncSpawn changes
diegomrsantos Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions libp2p/protocols/pubsub/pubsubpeer.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,11 @@ proc sendEncoded*(p: PubSubPeer, msg: seq[byte], isHighPriority: bool): Future[v

if msg.len <= 0:
debug "empty message, skipping", p, msg = shortLog(msg)
return

if msg.len > p.maxMessageSize:
Future[void].completed()
diegomrsantos marked this conversation as resolved.
Show resolved Hide resolved
elif msg.len > p.maxMessageSize:
info "trying to send a msg too big for pubsub", maxSize=p.maxMessageSize, msgSize=msg.len
return

if isHighPriority:
Future[void].completed()
elif isHighPriority:
p.clearSendPriorityQueue()
let f = p.sendMsg(msg)
if not f.finished:
Expand Down
Loading