Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default repo for avahi installation #1507

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

jordimassaguerpla
Copy link
Contributor

What does this PR change?

the default repo should have been in the "if" clause.

Signed-off-by: Jordi Massaguer Pla <[email protected]>
@mtravitzky
Copy link
Contributor

mtravitzky commented Feb 19, 2024

This change might bring back the issue mentioned here: #1447

because as the code is right now, with these lines outside the if-clause, it would have made the avahi installation work even if there weren't the right avahi packages in the custom repo. But I might be completely wrong.

@nodeg
Copy link
Member

nodeg commented Feb 19, 2024

I am not sure why this was initially changed so FMPOV, we can revert it and merge this PR, and then we should consider #1447 again.

@jordimassaguerpla jordimassaguerpla merged commit 36fe758 into uyuni-project:master Feb 19, 2024
2 checks passed
@mtravitzky
Copy link
Contributor

The issue in #1447 has not been brought back by this PR, so all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants