-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Clarify requirements for running on GPU and supported configurations #2286
base: main
Are you sure you want to change the base?
DOC: Clarify requirements for running on GPU and supported configurations #2286
Conversation
e4774ab
to
0bb6d30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work on this, the docs are much improved
- [CPU] | ||
- [CPU] | ||
- [CPU] | ||
*Note: the main Anaconda channel also provides distributions of scikit-learn-intelex, but it does not provide the latest versions, nor does it provide GPU-enabled builds. It is highly recommended to install it from either Intel's channel or conda-forge instead.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely true: conda-forge linux build contains dpc
and spmd_dpc
libs starting from 2025 release. However, GPU support is not tested for it due to HW unavailability in conda-forge-feedstock CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alexsandruss Thanks for the clarification.
But does the build from conda-forge differ from the build from intel-conda in some way that would affect GPU support? As I understand it, both of them are built with the exact same build-time dependencies (compiler, headers, TBB, MKL, MPI) in the exact same versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alexsandruss Thanks for the clarification.
But does the build from conda-forge differ from the build from intel-conda in some way that would affect GPU support? As I understand it, both of them are built with the exact same build-time dependencies (compiler, headers, TBB, MKL, MPI) in the exact same versions.
Toolchains are different: intel
conda channel used internal, conda-forge
- public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then again: what differences are there in those toolchains that could affect GPU support, if they are at the same version numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
This PR:
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.