remove unneeded code

uxlfoundation · Jan 29, 2025 · 7c22a2f · 7c22a2f
1 parent 9db52f7
commit 7c22a2f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/onedal/datatypes/dlpack/data_conversion.cpp b/onedal/datatypes/dlpack/data_conversion.cpp
@@ -32,9 +32,6 @@ inline dal::homogen_table convert_to_homogen_impl(managed_t* dlm_tensor,
     dal::homogen_table res{};
 
     DLTensor tensor = dlm_tensor->dl_tensor;
-#ifdef ONEDAL_DATA_PARALLEL
-
-#endif // ONEDAL_DATA_PARALLEL
 
     // get shape, if 1 dimensional, force col count to 1
     std::int64_t row_count, col_count;
@@ -174,7 +171,7 @@ dal::table convert_to_table(py::object obj, py::object q_obj) {
                             throw std::invalid_argument("Found unsupported array type"));
 #undef MAKE_HOMOGEN_TABLE
 
-    // take ownership of the capsule
+    // take ownership of the capsule, this is important to prevent data deletion
     dlpack_take_ownership(caps);
     return res;
 }

diff --git a/onedal/datatypes/dlpack/data_conversion.hpp b/onedal/datatypes/dlpack/data_conversion.hpp
@@ -35,6 +35,4 @@ namespace py = pybind11;
 
 dal::table convert_to_table(py::object obj, py::object q_obj = py::none());
 
-py::capsule construct_dlpack_capsule(const dal::table& input);
-
 } // namespace oneapi::dal::python::dlpack
Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,6 +35,4 @@ namespace py = pybind11;

		dal::table convert_to_table(py::object obj, py::object q_obj = py::none());

		py::capsule construct_dlpack_capsule(const dal::table& input);

		} // namespace oneapi::dal::python::dlpack