-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify private worker synchronization mechanism #754
Merged
pavelkumbrasev
merged 6 commits into
master
from
dev/alexey-katranov/simplify-thread-monitor
Feb 7, 2022
Merged
Simplify private worker synchronization mechanism #754
pavelkumbrasev
merged 6 commits into
master
from
dev/alexey-katranov/simplify-thread-monitor
Feb 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexei Katranov <[email protected]>
Signed-off-by: Alexei Katranov <[email protected]>
alexey-katranov
commented
Jan 27, 2022
aleksei-fedotov
previously approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: Alexei Katranov <[email protected]>
Signed-off-by: Alexei Katranov <[email protected]>
Signed-off-by: Alexei Katranov <[email protected]>
aleksei-fedotov
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks even better!
pavelkumbrasev
deleted the
dev/alexey-katranov/simplify-thread-monitor
branch
February 7, 2022 12:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify
thread_monitor
implementation because we do not needepoch
-based protectionSimplify private worker shutdown mechanism
Fix IPC server (missed part of Fix incorrect synchronization in private server #739)
- git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information