Cleanup & Refactor #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2a6bea2.
pbugni
requested changes
Feb 15, 2023
| ); | ||
|
|
||
| -- create web user w/ read only auth | ||
| create role web_anon nologin; |
There was a problem hiding this comment.
as we plan to discontinue sending a customized, pre-baked JWT with the claim "role": "event_logger", I would expect we need to bless the web_anon role with grants like those given to event_logger below?
There was a problem hiding this comment.
we need to bless the web_anon role with grants like those given to
event_logger
Thanks for the reminder! I hadn't tested writing values into logserver (only viewing existing data). I'll make sure to test that the web_anon role can write events without authentication
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: the diff for this PR is very messy. LMK if it's an issue, more than happy to re-write history so the PR diff is more readable
References
Errors Middleware cannot be used without an insecure workaround
oauth2-proxy traefik example
jonananas/traefik-oauth2-proxy