Add env vars to support shl creator and server logging #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-c
approved these changes
Jan 31, 2025
base/docker-compose.yaml
Outdated
| @@ -209,6 +212,7 @@ services: | |||
| image: ghcr.io/uwcirg/shl-ltt-server:${SHL_SERVER_IMAGE_TAG:-latest} | |||
| environment: | |||
| PUBLIC_URL: https://shl-server.${BASE_DOMAIN} | |||
| VERSION: ${SHL_SERVER_IMAGE_TAG:-"latest"} | |||
There was a problem hiding this comment.
The docker image tag won't provide much information on development servers, since they generally won't be tagged. You may want to use git describe output at build-time to populate this value.
Here's a PR the implements the CI, but you'll also need a way to consume that environment variable in the app code
There was a problem hiding this comment.
Thanks! Added that function to the builds here:
shl-creator: uwcirg/shl-ltt#27
shl-server: uwcirg/shl-ltt-server#3
and removed the use of the image tag in this change.
base/docker-compose.yaml
Outdated
| @@ -209,6 +212,7 @@ services: | |||
| image: ghcr.io/uwcirg/shl-ltt-server:${SHL_SERVER_IMAGE_TAG:-latest} | |||
| environment: | |||
| PUBLIC_URL: https://shl-server.${BASE_DOMAIN} | |||
| VERSION: ${SHL_SERVER_IMAGE_TAG:-"latest"} | |||
There was a problem hiding this comment.
This shouldn't need to be quoted, at least for YAML
Suggested change
| VERSION: ${SHL_SERVER_IMAGE_TAG:-"latest"} | |
| VERSION: ${SHL_SERVER_IMAGE_TAG:-latest} |
base/docker-compose.yaml
Outdated
| @@ -197,6 +197,9 @@ services: | |||
| VITE_OIDC_LOGOUT_ENDPOINT: https://keycloak.${BASE_DOMAIN}/realms/ltt/protocol/openid-connect/logout | |||
| VITE_OIDC_CHECK_SESSION_IFRAME: https://keycloak.${BASE_DOMAIN}/realms/ltt/protocol/openid-connect/login-status-iframe.html | |||
| VITE_POST_LOGOUT_REDIRECT_URI: https://${BASE_DOMAIN}/users | |||
| VITE_LOG_URL: https://shl-server.${BASE_DOMAIN}/api/log | |||
| VITE_SYSTEM_URL: https://shl-creator.${BASE_DOMAIN} | |||
| VITE_VERSION_STRING: ${SHL_CREATOR_IMAGE_TAG:-"latest"} | |||
There was a problem hiding this comment.
This shouldn't need to be quoted, at least for YAML
Suggested change
| VITE_VERSION_STRING: ${SHL_CREATOR_IMAGE_TAG:-"latest"} | |
| VITE_VERSION_STRING: ${SHL_CREATOR_IMAGE_TAG:-latest} |
shl-creator: uwcirg/shl-ltt#27 shl-server: uwcirg/shl-ltt-server#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.