consider mark-resolved when determining time since follow up #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achen2401
approved these changes
Nov 27, 2024
…olved-no-send` when looking up un-followed-up message times.
pbugni
force-pushed
the
feature/consider-resolved_no_send-communications
branch
from
0ee9f38 to
256989e
Compare
|
@pbugni it would be good to release this prior to @achen2401 's vacation starting Thursday. Re testing, this particular change seems simple enough, if you're done would you rather merge or switch dev to use this branch? |
I did set isacc-dev to test this branch as well as @achen2401 's front end changes in uwcirg/isacc-messaging-client-sof#99 @sierramatice did test this and "did not find any issues!" |
|
Note related front end changes in uwcirg/isacc-messaging-client-sof#99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/2584667/stories/188624366
look for Communication category
isacc-message-resolved-no-sendwhen looking up un-followed-up message times. this will catch the faux Communication marker added when user selects to [MARK MESSAGE AS READ/RESOLVED], and thus accurately calculatetime-of-last-unfollowedup-message