Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration moving #67

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Migration moving #67

merged 11 commits into from
Jun 25, 2024

Conversation

Filienko
Copy link

@Filienko Filienko commented Jun 15, 2024

Changing the isacc to reference the package instead. Requirements.txt will work when we update the fhir-migration package at main

@Filienko Filienko requested review from pbugni and ivan-c June 15, 2024 20:38
Copy link

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - one minor nit.

isacc_messaging/app.py Outdated Show resolved Hide resolved
@Filienko Filienko removed the request for review from ivan-c June 19, 2024 02:08
@Filienko Filienko marked this pull request as ready for review June 19, 2024 02:09
@Filienko Filienko changed the base branch from main to dev June 19, 2024 02:09
@Filienko Filienko merged commit c18a03b into dev Jun 25, 2024
2 checks passed
@Filienko Filienko deleted the migration-moving branch June 25, 2024 21:04
pbugni added a commit that referenced this pull request Jul 1, 2024
* Migration update (#65)

* WIP: starting migration work

* WIP: run_migration CLI

* Moving the migration into separate module

* WIP: migration class

* WIP: separating migratory functionality

* WIP: fixing naming

* Refactoring and adding mock tests

* Modifying tests

* WIP: fixing tests

* WIP: fixing tests

* WIP: tests

* WIP: fixing tests

* WIP: fixing test

* Fixing tests

* WIP: fixing tests

* WIP: fixing errors

* Fixing formatting

* Addressing comments

* Tests

* WIP: fixing tests

* WIP: fixing test

* Fixing tests

* WIP: working single tree

* Changed the migration from referencing the latest applied to the latest created file
(Reversable)

* Only allow migreation to be generated, if the system is caught up

* WIP: adding testing

* Removing tests

* Adding back the test case

* Fixing upgrade

* Fixing a test

* Changed to linked list

* WIP: adding test

* WIP: testing

* WIP: testing

* WIP: testing

* Fixing cycles

* WIP: adding eq

* Fixing cycles

* WIP: fixing cycles

* WIP: fixing migration

* WIP: fixing

* WIP: fixing migration

* WIP: fixing migration

* Testing cycle

* errors

* Fixing errors

* errors

* errors

* Refactoring Linked List utilities

* WIP: fixing cycles

* WIP: fixing cycles

* Fixing cycles

* Fixing data

* WIP:fix

* Testing

* WIP: fixing errors

* WIP: new

* WIP: fixing errors

* WIP: fixing cycle

* WIP: fixing errors

* Fixing errors

* WIP: fixing erros

* WIp: fixing

* fixing

* fixing circular

* Adding tests

* Changing logic

* utils

* fix list fixture

* fix

* Fixing test

* Responding to comments

* Fixing add

* Adding comments

* Fixing tests

* Fixing tests

* Tests

* Tests

* Fixed Test

* migration

* Fixing tests

* WIP: test

* WIP: file

* Fixing test

* WIP: fixing

* WIP: imp

* WIP: imp

* Removing .imp test

* WIP: removing test

* Adding property

* Decoupling name from version

* Enforce unique  migration names

* Fixing test

* Adding errors

* Testing added

* Fixing tests

* Errors

* New version

* Adding tests

* Fixing

* Adding tests

* Tests

* Modifying tests

* test

* Fixing tests

* Added example

* Small adjusments to the text

* Addressing comments
WIP: put

* Constant system comparison

* Adding temporary function to test direct PUT that is failing from within
the code.

* Left an exception where the implementation doesn't match the spec

* Ported away from HAPI_request, preferring requests on this module.
Eliminated a number of repeated strings using common variables
Use logging rather than print
When including query string parameters, use built in function
parameters, as special characters need to be URL encoded.

* Fixing

* Removing test

* Made migrations more robust

* Removing isacc

* Changing default number to uuid

---------

Co-authored-by: Paul F Bugni <[email protected]>

* Migration moving (#67)

Changing the isacc to reference the package instead. Requirements.txt will work when we update the fhir-migration package at main

---------

Co-authored-by: Daniil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants