Feature/deactivate account fix #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, make sure phone numbers would be reused
…wcirg/isacc-messaging-service into feature/deactivate-account-fix
pbugni
requested changes
Dec 28, 2023
pbugni
requested changes
Jan 12, 2024
pbugni
requested changes
Jan 18, 2024
There was a problem hiding this comment.
This looks good, but I'm concerned about on_twilio_message_received()
We don't include the active check when looking up a patient there, so if there happens to be 2 patients with the same phone number, first_in_bundle() could give you the in-active one.
I think you should modify the query there, and remove the pt.active checks below there.
achen2401
reviewed
Jan 18, 2024
achen2401
approved these changes
Jan 18, 2024
pbugni
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating CLI commands to disable and enable active as per https://www.pivotaltracker.com/story/show/185455581