fix malformed html in notification email #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achen2401 sorry, as I compare this with the new emails, I think we should keep the footer content consistent and that the new emails have a better format. I'll raise this with the team at 10:30 today, but I expect they'll agree. That's above the |
thank you @mcjustin I did just fix that |
mcjustin
approved these changes
Nov 15, 2023
ivan-c
approved these changes
Nov 20, 2023
pbugni
added a commit
that referenced
this pull request
Feb 20, 2024
* Added the cli command for a single parameter to update for all patients, make sure phone numbers would be reused * Added an inactive patient to test * Added an inactive patient to test * Cache Unchanged Layers (#50) * Fixup default branch * Prevent build version from invalidating cached pip installs * Reuse unchanged image layers when building on CI * fix malformed html in notification email (#54) * fix malformed html in notification email * fix based on feedback --------- Co-authored-by: Amy Chen <[email protected]> * WIP: modifying cli commands * WIP: localizing the error * WIP: fixing the cli error * Fixed CLI * WIP: fixing CLI * WIP: fixing cli command * WIP: reinstating abilities * Adding email headers {To, Date, Message-Id} to further decrease spam (#55) * Adding email headers {To, Date, Message-Id} to further decrease spam score. * Correct "EnvelopeFrom" address to match "From" header. * name kwargs for clarity, as per code review suggestion. * cli command to deactivate patient * WIP: adding CLI to deactivate patient * WIP: fixing deactivation CLI * WIP: fixing deactivation CLI * WIP: fixing CLI * WIP: Fixing CLI * WIP: fixing CLI * WIP: changing active from bool to str * WIP: experimenting with search values * WIP: fixing boolean search * WIP: fixing bool active * WIP: fixing bool * WIP: fixing active * WIP: fixing active bool * WIP: cleaning up the syntax * WIP: experimenting * WIP: fixed * Removing unncessary methods * Reinstated ability to deactivate a patient without active field * Remove the trailing whitespace * Addressing PR comments * Fixing get_active_user * Changing active check to be part of the query * Formatting * Raises a value error for inactive patient * Simple fix to add a log whenever message fails * WIP: Added a CLI to add start period for all patients without one * Add CLI to add start to all entries * Mark patient as active when 'start' included in the message * Correspond to Twilio's opt in word. * Use consistent format * Stop deactivating messages that the user may need * Fix the logic * Move calculations to shared timezone * Handling a case when phone number got removed from a patient * Handle subsubcribed error separately * Adding validating function for twilio * Returns 200 when unsubscribed in nonactive patient messages the sms twilio phone number * MessageStatus change to 200 * Added error logging * Altered all 500 codes to 200 * Introducing different CR statuses, according to the type of error. * Refactoring record creator methods into respective classes * changing a name of the function * WIP: communications refactoring work * Adding logs * Handling communications for unsubscribed patients * Finished refactoring * Disable the migration needed to update patient extensions, as it'll undo (#57) user actions with https://www.pivotaltracker.com/story/show/186783090 * Removing CR logic, represent state in the Communication * Fixing status appending * Refactoring * Refactoring to keep the communication creation in the single function * Worked: outgoing messages * Fixing record * Modified logs * Fixing status --------- Co-authored-by: Daniil <[email protected]> Co-authored-by: Ivan Cvitkovic <[email protected]> Co-authored-by: Amy Chen <[email protected]> Co-authored-by: Amy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/2584667/stories/186482827
addressed malformed html in notification email: