Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test data #7

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Feature/test data #7

wants to merge 17 commits into from

Conversation

daniellrgn
Copy link
Contributor

@daniellrgn daniellrgn commented Sep 14, 2023

Add test data for SANER and VRDR use cases

@daniellrgn daniellrgn self-assigned this Sep 14, 2023
Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Had some file naming suggestions but looks ready to merge otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the resourceType to the filename? eg 20230525.MeasureReport.ndjson

Although the Bulk FHIR spec requires each each ndjson file only contain one type of FHIR resourceType, there aren't any formal requirements on file naming patterns. However, the tools SMART-on-FHIR/SMART HealthIT have written around Bulk data roughly follow this format:

{n}.{resourceType}.ndjson

SMIT has a sandbox where you can see an interactive demo/test of Bulk Export (including a list of files) by clicking Try Sample App

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a README.md file to test/data/saner roughly describing the data/test scenario?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Bundle somewhere in the filename?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a README.md file to test/data/vrdr roughly describing the data/test scenario?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Bundle somewhere in the filename?

@ivan-c ivan-c self-requested a review October 2, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants