-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/test data #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Had some file naming suggestions but looks ready to merge otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the resourceType to the filename? eg 20230525.MeasureReport.ndjson
Although the Bulk FHIR spec requires each each ndjson file only contain one type of FHIR resourceType, there aren't any formal requirements on file naming patterns. However, the tools SMART-on-FHIR/SMART HealthIT have written around Bulk data roughly follow this format:
{n}.{resourceType}.ndjson
SMIT has a sandbox where you can see an interactive demo/test of Bulk Export (including a list of files) by clicking Try Sample App
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a README.md
file to test/data/saner
roughly describing the data/test scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Bundle
somewhere in the filename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a README.md
file to test/data/vrdr
roughly describing the data/test scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Bundle
somewhere in the filename?
9af8a37
to
9631707
Compare
Add test data for SANER and VRDR use cases