netsync, main: use utreexo proof message to validate blocks #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now able keep track of the requestedUtreexoProofs per peer.
…nager Because we need to have both the block and the utreexo proof in order to validate a block as a CSN, we must be able to hold onto the proof or the block until the other also arrives from the peer. Having the queue maps allow us to do that. The numLeaves allows us to keep track of leaves in memory from the utreexo headers that we received. We need this to construct the get utreexo proof message.
fetchHeaderBlocks We now ask for utreexo proofs and keep track of numLeaves which are needed for creating the GetUtreexoProofMsg.
Since the block will not have the utreexo proof attached to it, we need to add the utreexo proof to the block message before we pass it off for processing.
handleUtreexoProofMsg takes in the utreexo proof and just caches it until the processor for the block picks it up and uses it during block validation. If the block already exists, then we send the block to the blockHandler for it to be processed.
We send the utreexo proof to the SyncManager for processing now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utreexo proofs are no longer included in the block message. Instead, they're
separated out into their own message so the SyncManager needs to handle requesting
and handling both the block and the utreexo proof message.
In the changes made here, we keep track of the numLeaves from the utreexoHeaders and
we hold onto them as they're needed when constructing the GetUtreexoProof message.
Then we request the GetUtreexoProof message and request them while fetching the blocks
and add them to the blocks while processing the block messages.