-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Updated OSCAL CI/CD with Profile Checker #148
Integrate Updated OSCAL CI/CD with Profile Checker #148
Conversation
7fb9935
to
3ce2a83
Compare
3ce2a83
to
ba8070f
Compare
Updates are good but it fails for the reasons I expected:
Validation of extant src OSCAL JSON SSPs fail to due to usnistgov/metaschema#240 bug. Will hold off on merging this until that is resolved. https://github.com/usnistgov/oscal-content/actions/runs/3294342588/jobs/5431756943 |
…pdated Schematron name and value checker to run cleanly.
e4022c7
to
1f75384
Compare
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3.1.2 to 4.3.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@98f2ad0...13ae5bb) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Make sure that we keep the compiled Schematron->XSLT output for running the Schematron business rules and then store the SVRL output results for later debugging. NOTE: The collection of files in path runner.temp var for the GHA workflow is in main branch already as of d3c227d so I will not double-add it for now.
cfc671a
to
26dae01
Compare
be2fc30
to
17d7863
Compare
@aj-stein-nist Once we advance the submodules and the CI is fixed, I'll merge this. |
This will be merged once usnistgov/metaschema#253 is merged. This PR will need to be rebased to get the latest metaschema submodule. |
Committer Notes
This PR takes the OSCAL CI/CD enhancements for #128 and integrates them into this repo with actual profiles.
This is ready for review but not mergeable. Two conditions must be met.
origin
(usnistgov/OSCAL) that is a copy of the actualy PR in my fork (aj-stein-nist/OSCAL) has been updated, as I cannot configure the remote for inline PR testing and only make final merge of this more complex. That PR must be merged first.NOTE: I wanted to fully test this with a purposefully broken commit in b65f528 that reverted with a force push to clean this up as usnistgov/metaschema#240 continues to break other validation steps in CI, so this is not immediately mergeable and, here or in my fork, I cannot easily demonstrate it like I can in local docker-compose setup.
All Submissions:
Changes to Core Features:
Have you added an explanation of what your changes do and why you'd like us to include them?Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?