Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated camelCase types from XML Schemas #561

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Feb 29, 2024

Committer Notes

Goal 3/7 for #558.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.
  • Have you written new tests for your core changes, as applicable? N/A
  • Have you included examples of how to use your new feature(s)? Will update samples in another PR.

Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this.

@aj-stein-nist on a tangent, I wonder if you would be able to stand by / lend a hand with metaschema-xslt as this change propagates upwards? We are now in a much better position to regression test than hitherto, but it is still going to require more than one pair of eyes. 👀

@david-waltermire david-waltermire added this pull request to the merge queue Mar 4, 2024
Merged via the queue into usnistgov:develop with commit 6aa0533 Mar 4, 2024
3 checks passed
david-waltermire added a commit to GSA/metaschema that referenced this pull request Jul 22, 2024
… to restore use of these types, which are used in OSCAL. Refactored module constraints to fix Metapath errors. Removed keyword checks in names added by usnistgov#542, which is not needed, since these names are allowed.
@david-waltermire david-waltermire mentioned this pull request Jul 22, 2024
8 tasks
david-waltermire added a commit to david-waltermire/metaschema that referenced this pull request Jul 24, 2024
… to restore use of these types, which are used in OSCAL. Refactored module constraints to fix Metapath errors. Removed keyword checks in names added by usnistgov#542, which is not needed, since these names are allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants