Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for camelCase data types #560

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Feb 29, 2024

Committer Notes

Addresses goal 3/7 for #558.

image

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)? N/A but will adjust Deprecate legacy datatypes #558 criteria to include additional goal of reviewing examples, checked there are some old examples in repo (in checked samples and website content) using old camelCase style

@aj-stein-nist aj-stein-nist self-assigned this Feb 29, 2024
@aj-stein-nist aj-stein-nist marked this pull request as ready for review February 29, 2024 04:13
@aj-stein-nist aj-stein-nist mentioned this pull request Feb 29, 2024
10 tasks
@aj-stein-nist aj-stein-nist force-pushed the 558-deprecate-datatypes-website-notice branch from 2fdae16 to 398ff13 Compare February 29, 2024 04:30
Copy link
Contributor

@Arminta-Jenkins-NIST Arminta-Jenkins-NIST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committer Notes stated this PR addresses goal 3/7; however, I believe this is goal 7/7. Everything looks good.

@david-waltermire david-waltermire force-pushed the 558-deprecate-datatypes-website-notice branch from 398ff13 to 3480830 Compare March 15, 2024 13:19
@david-waltermire david-waltermire added this pull request to the merge queue Mar 15, 2024
Merged via the queue into usnistgov:develop with commit 0954786 Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants