-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Let Expressions #478
Support for Let Expressions #478
Conversation
…nt constructs in a section of the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording request and want to clarify and make sure I understand the scoping (context/sub-context) spec as written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My questions are less about the design than about process.
What are we promising if we merge this into develop
? Do we get to try the design and see? When is it appropriate to quibble about names or details such as what happens when two let
expressions have the same name (@var
, I guess it is), etc.
Similarly I wonder whether we could aspire to providing, with a design, some worked examples / functional demos, which we can use for testing and validation both of our conceptual models (addressing questions such as @aj-stein-nist) and of the tools we make.
Nice to see continued headway - thanks @david-waltermire-nist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let/@var
and let/@expression
are okay but why not (e.g.)
let/@var
and let/@expr
let/@variable
and let/@expression
Also I wonder if @eval
or @evaluate
might be more accurate than @expr
insofar as what is being passed is not an expression, but a binding to the results of an expression.
However these are not blocking questions inasmuch as others might also have suggestions for syntax improvements, so presumably later chances to discuss.
(I would actually like to see a process whereby the group could come up with 'best names' and syntax.)
Change |
54185be
* Cleaned up schema, adjusting some documentation and grouping constraint constructs in a section of the schema. * Added support for declaration of let expressions in constraints. * Added documentation about the let expression in the specification. * Added let example to specification. * Fixed some other inconsistencies in the Metaschema XML schema.
Committer Notes
Adding support for let expressions in constraints.
Also cleaned up the Metaschema XML schema, moving all constraint-related constructs to a section of the schema.
All Submissions:
Changes to Core Features:
[ ] Have you written new tests for your core changes, as applicable?