-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify allowed-values constraints #413
Clarify allowed-values constraints #413
Conversation
430be3d
to
4abfaef
Compare
@david-waltermire-nist this is still WIP but I would like your preliminary thoughts and know if you and others agree with the direction this is headed in before finalizing. |
091bd03
to
3e2a2a6
Compare
581379c
to
8e3d742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I have some remarks for discussion, no blockers.
Per discussion with @david-waltermire-nist I am tardy in some of the edits I said I would make prior and some other recommendations in an enhanced TODO list below. Outstanding items:
|
cc2a34d
to
5d49588
Compare
8ad28e0
to
e807cba
Compare
0d95aae
to
ba2e754
Compare
As part of usnistgov#411, use IETF BCP-14 languages as used with other parts of the specification. Change the wording to address how implementers would follow constraint directives in their processor, and align example to be like computer model themes with tutorials and other documentation.
Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
Flesh out earlier draft with detailed coverage of allowed-values constraints and semantics. Define `@allow-other` and `@extension` attributes. Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: Wendell Piez <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
ba2e754
to
f22ea1b
Compare
Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
Co-authored-by: David Waltermire <[email protected]>
@david-waltermire-nist, re the checklist do you want me to squash commits now or after team and community review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of longer-term questions/concerns, nothing blocking.
Nice work here!
Fix typo pointed out by @wendellpiez in PR review, ignore->ignored, in the section about the target attribute. Co-authored-by: Wendell Piez <[email protected]>
Also @david-waltermire-nist per the checklist let me know if you want me to squash the commits from the heavy editing phase before we finalize this and close it out. |
I have usnistgov/metaschema-xslt#91 on this. The current implementation of the InspectorXSLT Metaschema transpiler works only when @target paths conform to the 'pattern subset' of XPath defined for XSLT. https://www.w3.org/TR/xslt-30/#pattern-syntax FWIW, the reason the code has this limitation at all is because it started as a mapping of Metaschema rules to Schematron, in which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I am going to merge this since it has been well reviewed.
* Update allowed-values overview. As part of #411, use IETF BCP-14 languages as used with other parts of the specification. Changed the wording to address how implementers would follow constraint directives in their processor, and align example to be like computer model themes with tutorials and other documentation. * Corrected poorly worded assembly constraint explanation. * Fleshed out earlier draft with detailed coverage of allowed-values constraints and semantics. Define `@allow-other` and `@extension` attributes. * Add `@id`, `@level`, and `@target` for #411. * Reorganization of common constraint data section and intro. --------- Co-authored-by: David Waltermire <[email protected]> Co-authored-by: Wendell Piez <[email protected]>
Committer Notes
Closes #411.
All Submissions:
Changes to Core Features:
Have you written new tests for your core changes, as applicable?