Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: some improvements on separate init branch #17

Conversation

jat255
Copy link
Member

@jat255 jat255 commented Nov 4, 2024

Per our conversation on Friday...

  • Slicing with a single location with isig now emits a warning, and coerces the shape to (ntilts | 1, y) :
>>> s = ds.get_catalyst_data(misalign=False)
>>> s.isig[20, :]
Slicing a TomoStack signal axis with a single pixel is not supported. Returning a single pixel on the "x" axis instead
<TomoStack, title: , dimensions: (90|1, 600)>

>>> s.isig[:, 200]
Slicing a TomoStack signal axis with a single pixel is not supported. Returning a single pixel on the "y" axis instead
<TomoStack, title: , dimensions: (90|600, 1)>
  • Added an extract_sinogram() method that supports both integer and float-based indexing:

image

  • Fixed some axes-handling issues that were causing tests to fail.

Todos:

  • Test/check test output of CUDA code
  • Add coverage for RecStack constructor
  • A few other little things I found

But wanted you to see this so we don't duplicate efforts

- implement "extract_sinogram" (needs tests)
- fix failing test due to string reformatting
Clean up axes testing/naming logic and add tests for coverage on this
Fix signal_type on extract_sinogram
Add tests for extract_sinogram
@jat255 jat255 marked this pull request as draft November 4, 2024 05:35
@jat255
Copy link
Member Author

jat255 commented Nov 4, 2024

Closing in favor of #18, which is direct to master

@jat255 jat255 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant