Propose ADR for Data Governance and Release Management for oscal-content #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
3 tasks
aj-stein-nist
force-pushed
the
116-oscal-content-data-release-governance-adr
branch
2 times, most recently
from
9f52250 to
f1c9c1a
Compare
aj-stein-nist
force-pushed
the
116-oscal-content-data-release-governance-adr
branch
2 times, most recently
from
77220dc to
97c601d
Compare
aj-stein-nist
added a commit
to usnistgov/oscal-content
that referenced
this pull request
Oct 13, 2023
There are a number of changes we need to make to the structure and the organization of example documents in the repository to improve the maintainability and stability of building examples. 1. We need to remove now invalid docs, e.g. #208. 1. Remove JSON examples in src and convert them to XML first. 1. Remove old draft and FedRAMP directories, warning has been up for long enough. 1. Remove old notes in src/examples/ssp/xml directory that are not examples. 1. Relocate oscal submodule to build/oscal to match style of other repositories in the project. 1. Update for OSCAL v1.1.1 release of models. 1. Align SP 800-53 Rev 5 catalog version with guidance in ADR in usnistgov/OSCAL#1947, make version correctly 5.1.2. 1. Update last-modified, published, and version metadata as applicable. 1. Add jq and yq dependency install.
wendellpiez
previously approved these changes
Oct 13, 2023
There was a problem hiding this comment.
We very much need this or something like it.
Bravo AJ for bringing this forward. As you know I don't agree 100% with every point - all the more reason to agree to this in principle, so we can act on it, making any subsequent refinements meaningful. I look forward to conversations.
nikitawootten-nist
requested changes
Oct 13, 2023
nikitawootten-nist
previously approved these changes
Oct 13, 2023
|
I will merge this after usnistgov/oscal-content#204, since this will need to happen alongside that. Merging that PR means we are ready to roll. ⚡ |
iMichaela
previously approved these changes
Oct 13, 2023
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content
that referenced
this pull request
Oct 20, 2023
There are a number of changes we need to make to the structure and the organization of example documents in the repository to improve the maintainability and stability of building examples. 1. We need to remove now invalid docs, e.g. usnistgov/oscal-content#208. 1. Remove JSON examples in src and convert them to XML first. 1. Remove old draft and FedRAMP directories, warning has been up for long enough. 1. Remove old notes in src/examples/ssp/xml directory that are not examples. 1. Relocate oscal submodule to build/oscal to match style of other repositories in the project. 1. Update for OSCAL v1.1.1 release of models. 1. Align SP 800-53 Rev 5 catalog version with guidance in ADR in usnistgov/OSCAL#1947, make version correctly 5.1.2. 1. Update last-modified, published, and version metadata as applicable. 1. Add jq and yq dependency install.
aj-stein-nist
added a commit
to usnistgov/oscal-content
that referenced
this pull request
Oct 24, 2023
There are a number of changes we need to make to the structure and the organization of example documents in the repository to improve the maintainability and stability of building examples. 1. We need to remove now invalid docs, e.g. #208. 1. Remove JSON examples in src and convert them to XML first. 1. Remove old draft and FedRAMP directories, warning has been up for long enough. 1. Remove old notes in src/examples/ssp/xml directory that are not examples. 1. Relocate oscal submodule to build/oscal to match style of other repositories in the project. 1. Update for OSCAL v1.1.1 release of models. 1. Align SP 800-53 Rev 5 catalog version with guidance in ADR in usnistgov/OSCAL#1947, make version correctly 5.1.2. 1. Update last-modified, published, and version metadata as applicable. 1. Add jq and yq dependency install.
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Oct 27, 2023
There are a number of changes we need to make to the structure and the organization of example documents in the repository to improve the maintainability and stability of building examples. 1. We need to remove now invalid docs, e.g. usnistgov#208. 1. Remove JSON examples in src and convert them to XML first. 1. Remove old draft and FedRAMP directories, warning has been up for long enough. 1. Remove old notes in src/examples/ssp/xml directory that are not examples. 1. Relocate oscal submodule to build/oscal to match style of other repositories in the project. 1. Update for OSCAL v1.1.1 release of models. 1. Align SP 800-53 Rev 5 catalog version with guidance in ADR in usnistgov/OSCAL#1947, make version correctly 5.1.2. 1. Update last-modified, published, and version metadata as applicable. 1. Add jq and yq dependency install.
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Oct 27, 2023
There are a number of changes we need to make to the structure and the organization of example documents in the repository to improve the maintainability and stability of building examples. 1. We need to remove now invalid docs, e.g. usnistgov#208. 1. Remove JSON examples in src and convert them to XML first. 1. Remove old draft and FedRAMP directories, warning has been up for long enough. 1. Remove old notes in src/examples/ssp/xml directory that are not examples. 1. Relocate oscal submodule to build/oscal to match style of other repositories in the project. 1. Update for OSCAL v1.1.1 release of models. 1. Align SP 800-53 Rev 5 catalog version with guidance in ADR in usnistgov/OSCAL#1947, make version correctly 5.1.2. 1. Update last-modified, published, and version metadata as applicable. 1. Add jq and yq dependency install.
9 tasks
aj-stein-nist
dismissed stale reviews from nikitawootten-nist and iMichaela
via
9531816
Thanks for catching this, @nikitawootten-nist.
…backwards compatible.
aj-stein-nist
force-pushed
the
116-oscal-content-data-release-governance-adr
branch
from
9531816 to
d3a76c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This decision relates to future management of oscal-content#116.
All Submissions:
Do all automated CI/CD checks pass?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.