Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task queuing support #278

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: task queuing support #278

wants to merge 4 commits into from

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jan 13, 2025

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Implementation for task queues. This allows for limiting the number of total tasks and tasks per namespace to help reduce the number of tasks that could cause problems with pod limits in clusters with limited resources.

Has two control variables to use

  • qos-max-tasks
    • This controls the maximum number of tasks the controller will allow to run at the same time
  • qos-max-namespace-tasks
    • This controls the number of tasks per namespace that can be run

If max-tasks is lower than max-namespace-tasks, then the value of max-tasks is the limit.

Additionally, some limited test coverage for task qos, and also build qos, has been added.

Closing issues

closes #69
closes #2

@shreddedbacon shreddedbacon force-pushed the task-qos branch 5 times, most recently from 72433ce to 93be486 Compare January 14, 2025 00:52
@shreddedbacon shreddedbacon changed the title feat: task qos feat: task queuing support Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for tasks Write tests
1 participant